Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CustomerServiceContactDetails and updates Vehicle/VehicleRef #584

Merged
merged 20 commits into from
Jul 25, 2024
Merged

Added CustomerServiceContactDetails and updates Vehicle/VehicleRef #584

merged 20 commits into from
Jul 25, 2024

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Dec 12, 2023

fixes #401

@Aurige Where would I put vehicles in the GeneralFrame? I think I can't add vehicles or Fleet there? Or did I miss something?

@ue71603 ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated needs transmodel update labels Dec 12, 2023
@ue71603 ue71603 mentioned this pull request Dec 12, 2023
Closed
ue71603 and others added 2 commits December 12, 2023 18:11
@ue71603
added VehicleRef to ServiceJourney
7b69a31 
and I think a Type and a Vehicle might be possible.
Added example from @codeape2
@github-actions
Lint and update documentation tables
ce54bd5
@ue71603 ue71603 mentioned this pull request Dec 12, 2023
Closed
@ue71603 ue71603 changed the title Added CustomerServiceContactDetails Added CustomerServiceContactDetails and updates Vehicle/VehicleRef Dec 12, 2023
@ue71603 ue71603 mentioned this pull request Dec 12, 2023
Closed
@Aurige
Copy link
Contributor

Aurige commented Dec 12, 2023

@Aurige Where would I put vehicles in the GeneralFrame? I think I can't add vehicles or Fleet there? Or did I miss something?

There is a MobilityServiceFrameGroup with all you need but it is in a MobilityServiceFrame !!

@skinkie
Copy link
Contributor

skinkie commented Dec 12, 2023

@Aurige Where would I put vehicles in the GeneralFrame? I think I can't add vehicles or Fleet there? Or did I miss something?

There is a MobilityServiceFrameGroup with all you need but it is in a MobilityServiceFrame !!

So that should be added to the GeneralFrame?

@Aurige
Copy link
Contributor

Aurige commented Dec 12, 2023

The GeneralFrame includes any DatamanagedObject, so that's automatic for all first class objects

skinkie
skinkie reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like!

But question, shouldn't vehicleRef / VehicleTypeRef be a choice?

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 12, 2023

I pondered it. But then thought you may have both. But I think we can briefly discuss this with @Aurige

@skinkie
Copy link
Contributor

skinkie commented Dec 12, 2023

I pondered it. But then thought you may have both. But I think we can briefly discuss this with @Aurige

In my perspective a Vehicle is part of a VehicleType, and the VehicleType may not conflict with a Vehicle.

@ue71603 ue71603 assigned ue71603 and nick-knowles and unassigned ue71603 Dec 14, 2023
@nick-knowles
Copy link
Contributor

A VEHICLE is an instance of a VEHICLE TYPE, not part of it
A VEHICLE may be part of a FLEET.

VEHICLES and FLEETs may be declared in a RESOURCE FRAME (we should probbaly have a separate frame for all vehicle related stuff likr vehicles, vehilce types and deck plans - future)

@nick-knowles
Copy link
Contributor

nick-knowles commented Apr 15, 2024 •
edited
Loading

COntact details have been added to VEHICLE in Netex and Transmodel UML models

image

@nick-knowles
Copy link
Contributor

Transmodel also updated
image

@nick-knowles
Copy link
Contributor

VEHICLE MODEL PROFILE mssing from Transmodel RESOURCE FRAME diagram a- added

image

ALready shown in NeTEx model
image

ue71603 and others added 3 commits June 5, 2024 14:18
@ue71603
changed equipmentProfiles
4ab1889 
I don't really like breaking example (unless they were obviously wrong)
The VehicleCodeGroup is only used once (in VehicleGroup): so I would remove the equipmentProfiles and VehicleModelProfileRef from it and move them to this line 182 (in fact just remove them from VehicleCodeGroup and add equipmentProfiles before VehicleModelProfileRef of line 182 ...
removed tmp0000. checked examples
@ue71603
modeled the Contacts correct and corrected that contacts must allow m…
7a7e971 
…ultiple Contact
@github-actions
Lint and update documentation tables
ae93675
@ue71603 ue71603 removed their assignment Jun 5, 2024
Aurige
Aurige reviewed Jun 7, 2024
View reviewed changes
examples/functions/newModes/NewModes-CarClubExample.xml
@@ -374,6 +379,7 @@
<members>
<Vehicle version="any" id="car_01">
<OperatorRef version="any" ref="coc:MCR"/>
<ContactRef ref="contact1" version="any"/>
<SimpleVehicleTypeRef version="any" ref="small_car"/>
<VehicleModelRef version="any" ref="mini_whiz"/>
<CarModelProfileRef version="any" ref="model_a"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm puzzled because this still does not validated (error on CarModelProfileRef ) as if the VehicleCodeGroup has changed position... but it does not seem to be the case !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aurige What is not validating?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NeTEx\examples\functions\newModes\NewModes-CarClubExample.xml (and it validates in master, so we broke something at some point)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aurige to provide the details of the error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aurige for me it validates in the branch..
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes coming from this code are here. It is only Contact and ContactRef. However, we might have changed it before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is going on, but when I checkout that brach and validate the CarClub example, I get this (I just double checked)
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same pb with XMLLint

image

@ue71603
Copy link
Contributor Author

ue71603 commented Jul 8, 2024

@Aurige Sorry, I can't do nothing. It is valid on my end. I think you must find the error on your side.

@Aurige
Copy link
Contributor

Aurige commented Jul 10, 2024

Ok, I found the issue (a weird network error between Github Desktop and Github site ... with no error at check out, until you re-ask for Fetch). Sorry for bothering !

@Aurige Aurige merged commit 3465eec into next Jul 25, 2024
1 check passed
@Aurige Aurige added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Oct 18, 2024
@Aurige
Copy link
Contributor

Aurige commented Oct 18, 2024

Part 1 was updated (includes multiple PRs on Vehicle Element)

@skinkie skinkie deleted the Customer-Information-On-Vehicle branch November 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@Aurige Aurige Aurige approved these changes

@skinkie skinkie Awaiting requested review from skinkie

@JohanEntur JohanEntur Awaiting requested review from JohanEntur

Assignees

@ue71603 ue71603

Labels
document has been updated NeTEx Document already updated enhancement non semantic enhacement: technical enhancement, etc. needs transmodel update
Projects
None yet
Milestone
netex_2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ue71603 @Aurige @skinkie @nick-knowles @JohanEntur @trurlurl