Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description multi lingual string next #595

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Dec 13, 2023

No description provided.

@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Dec 13, 2023
@skinkie skinkie self-assigned this Dec 13, 2023
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 13, 2023
@ue71603 ue71603 requested a review from nick-knowles December 14, 2023 15:50
@ue71603 ue71603 merged commit 2f9e02a into next Dec 19, 2023
1 check passed
@ue71603 ue71603 deleted the Update_Description_MLS_next branch December 19, 2023 18:05
@nick-knowles
Copy link
Contributor

nick-knowles commented Dec 20, 2023

Hi STefan

I thought we very specifically agreed that Codespace description should not be a Multilingual string - I said that three times over! Sorry if it was not clear.
The description of Codespace is metadata for developer only use and will never be seen by end users, so doesnt need translating.

Making codespace use a complex type rather than a simple string introduces an unnecessary dependency into the ur package that I especially think we should avoid .
Can you revert the change make it a string again please?

The same principle goes for the documentation on versions and delta trace but I am less fussed about that as the packages they are in already depend on the added types

BTW Making it multistring also means The individual xml schema file no longer validates - please try and keep files independently validable.

Why is it a bad idea? because if later on we revise MultilingualSstring to allow alternative texts etc (as we are discussing) , we will then force all that further complexity (and possibly further dependencies on other modules) onto a kernel internal element. Note that CODE SPACE entity is an exception in other ways - eg it isn't versioned .

@skinkie
Copy link
Contributor Author

skinkie commented Dec 20, 2023

@nick-knowles can you please give us an example of a file that now does not validate? Or do you mean something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants