Remove datedCalls, and when it is valid, make it Calls #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinkie
added
the
enhancement
ue71603
approved these changes
Dec 13, 2023
|
Fix #568 |
trurlurl
approved these changes
Dec 14, 2023
| @@ -175,9 +175,9 @@ Rail transport, Roads and Road transport | |||
| <xsd:documentation>PASSING TIMEs for JOURNEY.</xsd:documentation> | |||
| </xsd:annotation> | |||
| </xsd:element> | |||
| <xsd:element name="datedCalls" type="datedCalls_RelStructure" minOccurs="0"> | |||
| <xsd:element name="datedCalls" type="calls_RelStructure" minOccurs="0"> | |||
There was a problem hiding this comment.
I guess the name has been left unchanged deliberataly, to ensure compatibility.
There was a problem hiding this comment.
They are still dated (since in DatedVJ) but can use the traditional Call structure (no need for a dated version)
Aurige
approved these changes
Dec 14, 2023
| @@ -175,9 +175,9 @@ Rail transport, Roads and Road transport | |||
| <xsd:documentation>PASSING TIMEs for JOURNEY.</xsd:documentation> | |||
| </xsd:annotation> | |||
| </xsd:element> | |||
| <xsd:element name="datedCalls" type="datedCalls_RelStructure" minOccurs="0"> | |||
| <xsd:element name="datedCalls" type="calls_RelStructure" minOccurs="0"> | |||
There was a problem hiding this comment.
They are still dated (since in DatedVJ) but can use the traditional Call structure (no need for a dated version)
|
This requires a change to the Documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.