Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessRightParameterAssignment - TypeOfProofRef #599

Merged
merged 11 commits into from
Jun 22, 2024
Merged

AccessRightParameterAssignment - TypeOfProofRef #599

merged 11 commits into from
Jun 22, 2024

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Dec 13, 2023

fixes #517

@ue71603 ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated labels Dec 13, 2023
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 13, 2023
@ue71603 ue71603 mentioned this pull request Dec 13, 2023
Closed
@Aurige
Copy link
Contributor

Aurige commented Dec 14, 2023

@nick-knowles to provide the proper place to add it

@ue71603
Copy link
Contributor Author

ue71603 commented Apr 10, 2024

@skinkie @Aurige @trurlurl pls review.

@nick-knowles
Copy link
Contributor

nick-knowles commented Apr 15, 2024 •
edited
Loading

SHould be in the ProductValidityParameters group of the validity parameters Need to decide if it is just one ref , a list of enums or a list of open value s in a wrapper tag though. Most validity parameters are just one ref - if you want multiple refs you just have multiple validty parameters.

image

@ue71603 ue71603 assigned ue71603 and unassigned nick-knowles Apr 16, 2024
@ue71603 ue71603 requested a review from skinkie May 30, 2024 14:13
@ue71603 ue71603 removed their assignment May 30, 2024
@Aurige
Copy link
Contributor

Aurige commented Jun 4, 2024

Deprecate typesOfProofRequiredRef and typeOfProofRef and Keep only typesOfProofAcceptedRef

@ue71603 ue71603 self-assigned this Jun 5, 2024
@ue71603 ue71603 removed their assignment Jun 5, 2024
@nick-knowles
Copy link
Contributor

UML updated with rename- CEN spec still to do

image

@ue71603
Copy link
Contributor Author

ue71603 commented Jun 22, 2024

@skinkie if ok for you, pls merge.

@skinkie skinkie merged commit 2583637 into next Jun 22, 2024
1 check passed
@skinkie skinkie deleted the AccessRightParameterAssignment---TypeOfProofRef- branch June 22, 2024 20:14
@duexw
Copy link
Collaborator

duexw commented Sep 3, 2024 •
edited
Loading

Updated documentation of ProductValidityParametersGroup and UserProfileGroup - but TypeOfProof does not seem to be documented yet. Should I document it? And if so, then in which section

@Aurige
Copy link
Contributor

Aurige commented Sep 3, 2024

I would briefly document it just after "7.6.1.3.6.4.3 ProofRequired – Allowed values"
But TypeOfProof is in fact an open ended TypeOfValue so there is not much to say ... may be just a few words in the tables will be enough

@duexw duexw added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@Aurige Aurige Aurige approved these changes

@skinkie skinkie skinkie approved these changes

@nick-knowles nick-knowles Awaiting requested review from nick-knowles

Assignees
No one assigned
Labels
document has been updated NeTEx Document already updated enhancement non semantic enhacement: technical enhancement, etc.
Projects
None yet
Milestone
netex_2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ue71603 @Aurige @nick-knowles @duexw @skinkie @trurlurl