Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate LineEquipment air conditioning #601

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Integrate LineEquipment air conditioning #601

merged 3 commits into from
Dec 19, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Dec 13, 2023

fixes #480

@ue71603 ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated labels Dec 13, 2023
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 13, 2023
@ue71603 ue71603 mentioned this pull request Dec 13, 2023
Closed
@ue71603 ue71603 changed the title include the new FAciclities Integrate LineEquipment air conditioning Dec 13, 2023
ue71603
ue71603 commented Dec 14, 2023
View reviewed changes
xsd/netex_framework/netex_reusableComponents/netex_facility_support.xsd Outdated
@@ -358,6 +358,21 @@ Rail transport, Roads and Road transport
<xsd:enumeration value="other"/>
</xsd:restriction>
</xsd:simpleType>
<xsd:simpleType name="EnvironmentControlEnumeration">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick: ClimateControl

@ue71603 ue71603 merged commit 446d22a into next Dec 19, 2023
1 check passed
@ue71603 ue71603 deleted the Integrate-LineEquipment-air-conditioning branch December 19, 2023 18:03
@nick-knowles
Copy link
Contributor

UML Documentation added.

NOTE : Should also add CLimateControl and LightingControl to NeTEx Accommodation element as facility may be specific to an accomodation type, eg 1st class berth might have blinds and aircon.

Netex Facility values UML
image

Netex Accommodation model UML
image

@trurlurl trurlurl added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurige Aurige Aurige approved these changes

@skinkie skinkie skinkie approved these changes

@nick-knowles nick-knowles Awaiting requested review from nick-knowles

@duexw duexw Awaiting requested review from duexw

@trurlurl trurlurl Awaiting requested review from trurlurl

Assignees
No one assigned
Labels
document has been updated NeTEx Document already updated enhancement non semantic enhacement: technical enhancement, etc.
Projects
None yet
Milestone
netex_2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ue71603 @nick-knowles @skinkie @Aurige @trurlurl