Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the examples from Norway & change Covered from boolean to enumeration #683

Merged
merged 11 commits into from
Apr 19, 2024

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Mar 18, 2024

Fix #682

@skinkie skinkie added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated UML update needed Update UML physical model needed labels Mar 18, 2024
@skinkie skinkie added this to the netex_2.0 milestone Mar 18, 2024
@skinkie skinkie requested review from Aurige, ue71603 and trurlurl March 18, 2024 14:02
@skinkie skinkie self-assigned this Mar 18, 2024
@skinkie
Copy link
Contributor Author

skinkie commented Mar 18, 2024

@ue71603 want to discuss tomorrow or merge

@ue71603
Copy link
Contributor

ue71603 commented Mar 19, 2024

@skinkie if we get a go from ENTUR, then i would say merge.

@ue71603 ue71603 assigned ue71603 and unassigned skinkie Apr 10, 2024
@ue71603
Copy link
Contributor

ue71603 commented Apr 10, 2024

@skinkie if ok for you, then merge.

@skinkie
Copy link
Contributor Author

skinkie commented Apr 10, 2024

I recall @trurlurl mentioned we needed to add true / false. I don't know why it is not in this one.

@ue71603
Copy link
Contributor

ue71603 commented Apr 11, 2024

@skinkie I think we discussed it. However, it is not in here. So where do we go... multiple booleans? enumeration ? list? @trurlurl

@trurlurl
Copy link
Collaborator

@skinkie I think we discussed it. However, it is not in here. So where do we go... multiple booleans? enumeration ? list? @trurlurl

The idea was to add "True" and "False" to CoveredEnumeration.

@ue71603
Copy link
Contributor

ue71603 commented Apr 11, 2024

@skinkie I think we discussed it. However, it is not in here. So where do we go... multiple booleans? enumeration ? list? @trurlurl

The idea was to add "True" and "False" to CoveredEnumeration.

added now

@skinkie
Copy link
Contributor Author

skinkie commented Apr 11, 2024

The strange thing is: I recall I added it.

@trurlurl
Copy link
Collaborator

The strange thing is: I recall I added it.

That's not so strange. When planning and starting to do something, the projected imagination of having achieved the goal may remain as persistent memory if the execution of the action sequence and the accompanying attentional processes has been completely interrupted and abandoned because of some external event. What remains is a false memory of having achieved the goal. At least, that's a theory how things work that I recall having either found or elaborated myself - but strangely I don't remember any more details about it...

@skinkie
Copy link
Contributor Author

skinkie commented Apr 11, 2024

The strange thing is: I recall I added it.

That's not so strange. When planning and starting to do something, the projected imagination of having achieved the goal may remain as persistent memory if the execution of the action sequence and the accompanying attentional processes has been completely interrupted and abandoned because of some external event. What remains is a false memory of having achieved the goal. At least, that's a theory how things work that I recall having either found or elaborated myself - but strangely I don't remember any more details about it...

Lets put it this way, when you mentioned it in the last working group. I directly did it. So I wonder where it ended up.

@ue71603
Copy link
Contributor

ue71603 commented Apr 12, 2024

perhaps it was undone by #681?

@skinkie
Copy link
Contributor Author

skinkie commented Apr 12, 2024

I am not crazy.

cd00ea6

@trurlurl
Copy link
Collaborator

I am not crazy.

cd00ea6

@skinkie I don't think anybody ever suspected you being crazy (except perhaps yourself) - I would rather have thought that another theoretical explanation would have applied in that case: that it was the universe who simply forgot the change you had done.

@ue71603 ue71603 removed their assignment Apr 17, 2024
@ue71603 ue71603 merged commit f0516e6 into next Apr 19, 2024
1 check passed
@ue71603 ue71603 deleted the examples_norway branch April 19, 2024 07:56
@trurlurl trurlurl added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document has been updated NeTEx Document already updated enhancement non semantic enhacement: technical enhancement, etc. UML update needed Update UML physical model needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants