Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neTactileActuators attribute on Escalators and Travelators #665tex_ifopt_equipmentAccess_version.xsd #720

Merged
merged 2 commits into from
May 3, 2024

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented May 2, 2024

fixes: #665

@ue71603 ue71603 added the bug Technical mistake, inconsistency with the documentation, etc. label May 2, 2024
@ue71603 ue71603 added this to the netex_1.3 milestone May 2, 2024
@ue71603 ue71603 requested review from skinkie, Joostb61 and trurlurl May 2, 2024 13:01
@@ -956,7 +956,7 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element name="TactileActuators" type="xsd:boolean" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Whether Lift has a tactile actuator.</xsd:documentation>
<xsd:documentation>Whether there are buttons to start the TRAVELATOR if it is not moving, and whether these buttons are intended and suited for the visually impaired.</xsd:documentation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these here are the TactileActuators of the LiftEquipment. The change for Escalator and Travelator is already done (cf. line 726), I introduced it as a commit in #705.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better with the new commit? @trurlurl

@@ -956,7 +956,7 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element name="TactileActuators" type="xsd:boolean" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Whether Lift has a tactile actuator.</xsd:documentation>
<xsd:documentation>Whether there are buttons to start the TRAVELATOR if it is not moving, and whether these buttons are intended and suited for the visually impaired.</xsd:documentation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that in the LiftButtonsGroup we have BrailleButtons, RaisedButtons, and TactileGroundFloorButton, then the only meaning that seems to make sense for me would be something like: "Whether at least the call buttons have tactile markers for the visually impaired." OR "Whether all buttons have tactile markers suited for the visually impaired." The second one sounds better to me, but I don't know what the initial intention was.

@skinkie skinkie merged commit 91b24bd into master May 3, 2024
1 check passed
@skinkie skinkie deleted the fix_incosistency_tactile_actuators branch May 3, 2024 16:29
skinkie pushed a commit that referenced this pull request May 6, 2024
…5tex_ifopt_equipmentAccess_version.xsd (#720)

* Update netex_ifopt_equipmentAccess_version.xsd

* Update xsd/netex_part_1/part1_ifopt/netex_ifopt_equipmentAccess_version.xsd
@trurlurl trurlurl added the document has been updated NeTEx Document already updated label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc. document has been updated NeTEx Document already updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TactileActuators attribute on Escalators and Travelators
3 participants