Lift buttons - improved descriptions #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disambiguating button descriptions.
trurlurl
added
bug
skinkie
approved these changes
Jul 5, 2024
|
Should these be propagated to master? |
ue71603
approved these changes
Jul 8, 2024
Aurige
approved these changes
Jul 9, 2024
|
I'll close this pull request. It is a bug fix and should have targeted master. |
trurlurl
removed
the
needs documentation update
|
Removed "needs documentation updated" since closed without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disambiguating button descriptions. Problem description in https://3.basecamp.com/3256016/buckets/2570434/messages/7227314680
Please check whether my correction regarding centimeters -> metres is OK (LengthType should always be metres, in my view).