Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labelling v2.0 changes, third series #781

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Labelling v2.0 changes, third series #781

merged 1 commit into from
Sep 25, 2024

Conversation

trurlurl
Copy link
Collaborator

3rd series series following #762 and #764.

I am through with the complete part 1 of the documentation. I only added labels for changes found in the document that are linked to a PR (i.e., that have a comment mentioning a PR).

  • That means, uncommented changes have not been treated. There are many of them.
  • For the pending PRs, we have to take care adding labels when merging and documenting them.

I was unsure what to do with changes preceding V2.0. Not in a consistent manner, I sometimes added +v1.3.1 or +v1.2.2 labels mainly. But was hesitating whether it makes sense to have some sparse +v1.3.1 labels at all because there haven't been many of them until now. The version is often just my best guess (v1.3.1, v1.3.0, v1.2.3, …) and should be reviewed.

I put "needs documentation update" on this PR because if you want me to remove or change some of the labels then this needs to be duplicated in the documentation.

@trurlurl trurlurl added the needs documentation update The NeTEx document needs to be updated label Sep 21, 2024
@trurlurl trurlurl added this to the netex_2.0 milestone Sep 21, 2024
@Aurige
Copy link
Contributor

Aurige commented Sep 23, 2024

Hello @trurlurl
Sorry for the slow answer (I was away and then sick ... still sick, I hope that I'll recover for Wednesday's meeting)
Our "official" CEN tags are 1.2.2 (New Modes), 1.3.1 (EPIAP) and the incoming 2.0
I'm not sure that it really helps users to be more accurate then this. As 1.2.2 is kind of expected to have the proper +v1.2.2 labels, we should be able to stick on +v1.3.1 and v2.0 whenever it is a headache to be more accurate.
... and thanks again for all this work !

@Aurige
Copy link
Contributor

Aurige commented Sep 23, 2024

Also, no need to track very old ones (like +v1.1) ... of course don't remove the one you added, but that's what people already have, and they probably don't care (and already know) that it was new at some point ;-)

Copy link
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any obvious mistake ... and that's all useful anyway

@Aurige Aurige merged commit 8bfc8df into next Sep 25, 2024
1 check passed
@trurlurl trurlurl added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Oct 21, 2024
@skinkie skinkie deleted the v2_labels_third_series branch November 19, 2024 10:25
@trurlurl trurlurl mentioned this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document has been updated NeTEx Document already updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants