Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of using privateCodes #811

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

First draft of using privateCodes #811

wants to merge 4 commits into from

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Dec 4, 2024

use privateCodes and no longer the depreciated PrivateCode:
#597

First version: Should it be done this way for all examples?

@ue71603 ue71603 added the enhancement non semantic enhacement: technical enhancement, etc. label Dec 4, 2024
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 4, 2024
@ue71603 ue71603 requested review from skinkie and Aurige December 4, 2024 12:37
@skinkie
Copy link
Contributor

skinkie commented Dec 4, 2024

The problem is 'with all examples' the obviously might be examples where it is not the first element. But give it a shot, if this is automatic. I think we can fix the exceptions more easily.

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 4, 2024

It never is. It is always in a different position, but I think the number is not too big

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 4, 2024

and having "most". would also be enough in my view.

@Aurige
Copy link
Contributor

Aurige commented Dec 4, 2024

That's fine to me.
That's also something that we can do in a longer run: fixing the examples does not require a CEN NWI or a document update ... so we can directly update master whenever we find a new one to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement non semantic enhacement: technical enhancement, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants