Add acl to near-token-contract #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfornet
reviewed
Oct 18, 2022
It allowed some cleanups thanks to recent updates in near-plugins.
|
The conflicts are resolved and the dependencies (near-plugins, workspaces) updated. |
|
What's new: Made the changes proposed in #24 and cleaned up several things (see commit messages for details). |
mfornet
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds access control based on
near-pluginstonear-token-contract.Running the following test verifies that access control is set up correctly:
If other developers using the acl plugin are expected to write similar tests, we might consider exporting test helpers from
near-plugins. Something similar to this.