Silo to silo transfers #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olga24912
reviewed
Aug 3, 2023
* integration test fro silo to silo * add aurora-sdk-integartion-test * split functions * add module * change balance * remove debug println * fmt * silo to engine transfer * withdraw test * fix withdraw * refactoring * check access controll * check if token is register * test error on withdraw from near * fix dependency * fix String to Uint * CI: add `silo-to-silo` tests * Silo2Silo: fix tests * CI; replace `true` with `recursive` * Update `.gitignore` * CI: try to fix path issue * CI: check submodule dir is exist * CI: install Foundry * Add yarn the command `test-token-silo-to-silo` * CI: call `prepare` * CI: add toolchain to `mock_token` * CI: add `actions-rs` * Ci: run `silo-to-silo` tests on ubuntu * CI: disable building from test * CI: add `add wasm32-unknown-unknown` command * CI: move down ` add wasm32-unknown-unknown` * CI: re-enable tests * CI: run tests in parallel * Apply `cargo fmt` * CI: use `self-hosted` * Ignore test `error_on_withdraw_to_near` --------- Co-authored-by: karim-en <[email protected]>
olga24912
approved these changes
Aug 24, 2023
sept-en
suggested changes
Sep 4, 2023
There was a problem hiding this comment.
There are many functions that accept an optional parameter but later have a default value in case the parameter is None. This makes reading and verifying the tests really hard, as you always need to remember the order of helper function args and what will be the default value in each case. Please avoid using default values, or at least specify them externally (or accept the arguments to the helper function as a structure).
Co-authored-by: Kirill <[email protected]>
olga24912
reviewed
Sep 26, 2023
paouvrard
suggested changes
Sep 27, 2023
olga24912
requested changes
Sep 29, 2023
* storage deposit outside contract test * long msg test * remove unused import * fix tests * fix tests * test transfer eth * test send eth back * eth withdraw test
* scripts for interactions * ft_transfer_call * Delete silo-to-silo/.openzeppelin/unknown-1313161554.json --------- Co-authored-by: Karim <[email protected]>
olga24912
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements a contract to make silo to silo transfers of the ERC20 tokens that are bridged from near.
The main public functions to interact with the contract:
To deploy the contract on testnet run:
To upgrade the contract on testnet run: