NEP141 connector: remove proof consumer #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiseln
requested changes
May 15, 2024
There was a problem hiding this comment.
I am happy with combining the contracts into one. I see no big reason for the proof consumer to be separate.
One more change that I considered doing for this contract is changing string errors to custom errors according to the modern solidity. I can work on it if it's something we want
| @@ -30,8 +29,8 @@ | |||
| "eslint-plugin-standard": "^4.0.0", | |||
| "eth-gas-reporter": "^0.2.17", | |||
| "ethereum-waffle": "^3.4.4", | |||
| "ethers": "^5.6.6", | |||
| "hardhat": "^2.10.1", | |||
| "ethers": "^6.12.1", | |||
There was a problem hiding this comment.
We have to updates the tests as well according to the new ethers version. It's a lot of code but should be straightforward
There was a problem hiding this comment.
Good catch, let's fix it in the follow-up PR
There was a problem hiding this comment.
Would rather do it here but up to you
kiseln
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProofConsumeras a separate contract by including it in the factory contract.