Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the bridge to work with chain signatures #248

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Upgrade the bridge to work with chain signatures #248

wants to merge 3 commits into from

Conversation

kiseln
Copy link
Contributor

@kiseln kiseln commented Aug 22, 2024 •
edited
Loading

Done:

  • ProofConsumer deleted
  • Factory is now initialized with a derived EVM address of a Near bridge contract
  • Deploy token changed to verify signature instead of Near proof
  • Deposit changed to verify signature instead of Near proof
  • Nonce validation performed to prevent replay attacks

Future work:

  • Fees?
  • Add Wormhole version for withdrawals

@kiseln kiseln requested a review from karim-en as a code owner August 22, 2024 13:45
@kiseln kiseln marked this pull request as draft August 22, 2024 13:46
karim-en
karim-en requested changes Sep 5, 2024
View reviewed changes
erc20-bridge-token/contracts/BridgeTokenFactory.sol
@@ -35,12 +35,30 @@ contract BridgeTokenFactory is
bool private _isWhitelistModeEnabled;

address public tokenImplementationAddress;
address public nearBridgeDerivedAddress;

mapping(uint128 => bool) private _completedTransfers;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it public so the front can check if it is completed or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karim-en karim-en karim-en requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiseln @karim-en