Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
In my application I have a use case where I use 128-bits UUIDs as IDs internally, and I would like to use these same IDs as Node and Link IDs when I use imnodes without having to truncate to
int
back and forth.This is why I basically added
using ID = int;
to imnodes, and added the possibility to override that definition ofID
inside "imnodes_config.h".A user-defined "imnodes_config.h" would look like this:
Changes
The two main (and maybe controversial) changes I hade to make are:
ImGuiStorage
's implementation from Dear ImGui into imnodes just to change the type of the ID used to index into that storage. But this also has the benefit of removing thestatic_cast
s fromint
toImGuiID
that were all over imnodes' implementation.NodeLineHandler()
that is used during serialization of the editor state. We now usestd::string
manipulations instead ofsscanf
to read and write theID
to and from strings. That is because we don't know how complex the user ID might be, and we have to let them handle the conversions. Usingstd::string
instead ofchar[]
is the simplest.