Fix wrong results in adhoc arithmetic for Zmodn_poly and UInt

Caught by new conformance tests for adhoc arithmetic
Nemocas · Nov 8, 2024 · 24fb717 · 24fb717
1 parent b439e0b
commit 24fb717
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/flint/nmod_poly.jl b/src/flint/nmod_poly.jl
@@ -172,8 +172,7 @@ end
 
 function *(x::T, y::UInt) where T <: Zmodn_poly
   z = parent(x)()
-  @ccall libflint.nmod_poly_scalar_mul_nmod(z::Ref{T}, x::Ref{T}, y::UInt)::Nothing
-  return z
+  return mul!(z, x, y % modulus(x))
 end
 
 *(x::UInt, y::T) where T <: Zmodn_poly = y*x
@@ -202,6 +201,7 @@ end
 
 function +(x::T, y::UInt) where T <: Zmodn_poly
   z = parent(x)()
+  y %= modulus(x)
   @ccall libflint.nmod_poly_add_ui(z::Ref{T}, x::Ref{T}, y::UInt)::Nothing
   return z
 end
@@ -232,6 +232,7 @@ end
 
 function -(x::T, y::UInt) where T <: Zmodn_poly
   z = parent(x)()
+  y %= modulus(x)
   @ccall libflint.nmod_poly_sub_ui(z::Ref{T}, x::Ref{T}, y::UInt)::Nothing
   return z
 end