ignore unconfirmed spent input #198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallet subscribes to mempool via tokio broadcast to track owned utxos. Changes: * add spent_utxos, unspent_utxos lists to WalletState struct * add WalletState::handle_mempool_event() * add test confirmed_and_unconfirmed_balance() * add Mempool::event_channel (tokio broadcast channel) * Mempool faillible mutation methods return Result() * Mempool mutable methods broadcast MempoolEvent * add tests::shared::mine_block_to_wallet() * lib.rs: spawn wallet task for listening to mempool events and dispatch to WalletState for handling. * add locks::tokio::AtomicRw::try_lock_guard_mut()
removes the mempool broadcast channel and wallet listener task.
Instead all mempool mutations go through GlobalState methods
which inform wallet of the changes. This makes changes atomic
over mempool+wallet so they are always in sync.
Changes:
* remove Mempool::event_channel
* Mempool &mut methods only callable by super
* Mempool &mut methods return MempoolEvent(s)
* add MempoolEvent::UpdateTxMutatorSet. (unused)
* add GlobalState methods: mempool_clear, mempool_insert,
mempool_prune_stale_transactions
* remove spawn_wallet_task from lib.rs
* add/improve doc-comments
closes Neptune-Crypto#189. input selection now ignores spent inputs from unconfirmed tx in the mempool. Also fixes an input selection bug where the balance check considers available funds (not timelocked) but the input utxo selection does not. Adds a test to verify that same input can no longer be spent twice.
Sword-Smith
reviewed
Oct 11, 2024
| @@ -470,7 +529,7 @@ mod tests { | |||
| use super::*; | |||
|
|
|||
| #[tokio::test] | |||
| pub async fn insert_then_get_then_remove_then_get() { | |||
| pub async fn insert_then_get_then_remove_then_get() -> Result<()> { | |||
There was a problem hiding this comment.
If the test does not return anything, then we get a nice stack trace whenever it fails. If the test returns some error, then the stack trace is not as useful, is my experience. For this reason, I prefer using unwrap or expect in tests, not the ? operator.
Sword-Smith
reviewed
Oct 11, 2024
Comment on lines
+63
to
+80
| /// Represents a mempool state change. | ||
| /// | ||
| /// For purpose of notifying interested parties | ||
| #[derive(Debug, Clone)] | ||
| pub enum MempoolEvent { | ||
| /// a transaction was added to the mempool | ||
| AddTx(Transaction), | ||
|
|
||
| /// a transaction was removed from the mempool | ||
| RemoveTx(Transaction), | ||
|
|
||
| /// the mutator-set of a transaction was updated in the mempool. | ||
| /// | ||
| /// (Digest of Tx before update, Tx after mutator-set updated) | ||
| UpdateTxMutatorSet(Digest, Transaction), | ||
| } | ||
|
|
||
| #[derive(Debug, GetSize)] |
There was a problem hiding this comment.
Two comments:
- Our files are growing pretty big. Can we have a separate file for this datatype?
- The MempoolEvent should only contain a
TransactionKernel. It doesn't need the transaction proof for anything, as the mempool already has that (where it's used for sharing transactions with peers and merging transactions when mining). TheMempoolEvents received by the wallet only need theTransactionKernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189.
Extends #184.
Alternative to #197. (we should choose one or the other)
This PR provides a fix for the issue reported in #189. Unlike #197, it does not implement unconfirmed tx chaining.
from commit msg: