-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OneTrainer on clouds #599
base: master
Are you sure you want to change the base?
OneTrainer on clouds #599
Conversation
- close in/out/err streams on paramiko exec_command, to hopefully avoid random hangs - check for empty path on uploading concept caption files - OneTrainer install command added to UI - implemented min download speed parameter
warning message for many uploads
runpod-python PR Nerogar#360 was merged and published. Remove warning and code path that for the previous version add requirements UI tooltip update
- use config.cloud.run_id only in detached case, otherwise timestamped files: callbacks were mixed up when 2 training runs were running on 2 pods sharing a storage Volume - set_keepalive for command connection: command connection isn't used unless you press buttons in the UI. remote sometimes closes unused connections without keepalive - new option config.cloud.delete_workspace - rename config.cloud.workspace_dir to remote_dir, to avoid confusion between OT workspace dir and remote dir (which contains the workspace dir) - start Jupiyter lab by default - propagate exceptions from the sync thread to the main thread, to avoid taking actions (such as deleting the pod or deleting the workspace dir) in case training was successful but downloads failed
…llback was received yet
…l embeddings download: #3
host: str | ||
port: int | ||
user: str | ||
huggingface_token: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the huggingface_token to the config is a problem. Config files are regularly shared. If the token is included in that file, users can unknowingly expose it. That's also the reason I haven't added a setting for this yet. It needs to be saved in some different place. It would also be pretty useful to have this setting outside the cloud training environment.
I could imagine having a different user specific config file that's never shared or exported. But I haven't really put a lot of thought into it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for runpod API key then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to use the same structure in the python code (derive a new class from BaseConfig, save that as a json file, use a UIState to display the values in the ui). The json file could be saved either in a new subdirectory or directly in the root directory. I don't really have a preference there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly different proposal here:
dxqbYD@08b5f64
By keeping the secrets within the config hierarchy, you avoid having to pass around two different config objects wherever you might need a secret
secrets.json:
{
"__version": 6,
"cloud": {
"__version": 0,
"api_key": "",
"id": "",
"huggingface_token": "",
"host": "",
"port": "0",
"user": "root"
}
}
Train on Linux-based remote hosts seamlessly, with some extra functionality for RunPod clouds. Details are best described in the UI tooltips below.
It is stable and fairly feature-complete now. More features and improvements have been requested by testers, which you can find listed here: https://github.com/dxqbYD/OneTrainer/issues
Let me know in case you find one or the other essential for the first merge, but in my view these are improvements.
A good starting point to read the code is
modules/trainer/CloudTrainer.py
. Everthing else follows from there.