ASTRACTL-33839 #358
Merged
ASTRACTL-33839 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palicena
reviewed
Jun 5, 2024
zachatnetapp
commented
Jun 5, 2024
| if [ -z "$_EXISTING_TRIDENT_OPERATOR_PULL_SECRETS" ]; then | ||
| patch_list+=',{"op":"replace","path":"/spec/template/spec/imagePullSecrets","value":['"$secret_obj"']}' |
There was a problem hiding this comment.
This is just for consistency. We don't have this $secret_obj variable in step_generate_torc_patch(), so I'd rather we do the same thing in both places. This came up with I was solving a merge conflict, otherwise I would not have even thought to touch this.
palicena
reviewed
Jun 5, 2024
palicena
reviewed
Jun 5, 2024
palicena
reviewed
Jun 5, 2024
Co-authored-by: Alice Paquette <[email protected]>
Co-authored-by: Alice Paquette <[email protected]>
palicena
reviewed
Jun 5, 2024
* ASTRACTL-32772: fix namespace/pull secret bug when prompts disabled * ASTRACTL-32772: fix kubectl apply not detecting errors if output after a warning * ASTRACTL-32772: cleanup
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the following scenarios:
Both of these cases are assuming that the our ACS registry (cr.astra.netapp.io) is being used. If not, it is up to the script user to handle their own secrets.
Also there are some other miscellaneous fixes that were already existing here #337 and that I needed for my changes to work right.