ASTRACTL-32772: bug fixes #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erator into ASTRACTL-32772-bug-fixes
palicena
commented
Jun 5, 2024
| add_problem "$ns_warning" | ||
| else | ||
| prompt_user "NAMESPACE" "$ns_warning. Please enter the namespace:" | ||
| fi |
There was a problem hiding this comment.
With prompts disabled, we were letting the user proceed without a NAMESPACE which would cause a fatal error down the road since we were trying to do operations involving an IMAGE_PULL_SECRET and relied on NAMESPACE also being set.
palicena
commented
Jun 5, 2024
| elif [ -z "$output" ] || [ -n "$line" ]; then | ||
| add_problem "Failed to apply kustomize resources: $line" | ||
| fi | ||
| done < <(echo "$captured_err") |
There was a problem hiding this comment.
If the apply command has both a set of warnings and errors, the warning would basically "hide" the actual errors since we were checking the whole string at once instead of line by line. We'd then continue with the rest of the script even though the apply failed.
Minimum allowed line rate is |
zachatnetapp
approved these changes
Jun 5, 2024
zachatnetapp
added a commit
that referenced
this pull request
Jun 6, 2024
* first steps * kubectl -k command works now * remove white space * feedback * stuff * Update unified-installer/astra-unified-installer.sh Co-authored-by: Alice Paquette <[email protected]> * Update unified-installer/astra-unified-installer.sh Co-authored-by: Alice Paquette <[email protected]> * dont remove thing we need * generate_docker_registry_secret function * get_trident_namespace * labels * ASTRACTL-32772: bug fixes (#362) * ASTRACTL-32772: fix namespace/pull secret bug when prompts disabled * ASTRACTL-32772: fix kubectl apply not detecting errors if output after a warning * ASTRACTL-32772: cleanup * error handling for trident-acp secret applying * labels! --------- Co-authored-by: Alice Paquette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for random bugs I found while testing some unrelated changes.