-
-
Notifications
You must be signed in to change notification settings - Fork 271
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Properly extract external_id from advanced search results (#478)
If you performed an advanced search specifying which columns to return and included externalId, you wouldn't be able to get the external_id from the resulting record via the usual external_id method. This now matches how internal_id is extracted. Prior to this, calls to external_id returned: ``` > record.external_id => {:@external_id=>"customer_1"} ``` Now, it returns: ``` > record.external_id => "customer_1" ```
- Loading branch information
Showing
3 changed files
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,8 @@ | |
|
||
expect(search.results.size).to eq(2) | ||
expect(search.current_page).to eq(1) | ||
expect(search.results.first.internal_id).to eq('123') | ||
expect(search.results.first.external_id).to eq('456') | ||
expect(search.results.first.alt_name).to eq('A Awesome Name') | ||
expect(search.results.last.email).to eq('[email protected]') | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters