Feature/remove ebs #95
Conversation
ayushisingh29
force-pushed
the
feature/remove-ebs
branch
4 times, most recently
from
10e5117
to
da86670
Compare
| # temporarily dont suggest EBS instances | ||
| if instance.drive is None: | ||
| return None | ||
|
|
||
| # if we're not allowed to use gp2, skip EBS only types | ||
| if instance.drive is None and require_local_disks: |
There was a problem hiding this comment.
can you just flip the default of require_local_disks to true?
There was a problem hiding this comment.
Good point. I have fixed it along with the tests.
tests/netflix/test_cassandra.py
Outdated
| @@ -78,70 +81,70 @@ def test_capacity_small_fast(): | |||
| assert small_result.cluster_params["cassandra.heap.table.percent"] == 0.11 | |||
|
|
|||
|
|
|||
| def test_ebs_high_reads(): | |||
There was a problem hiding this comment.
if you did it with the param then you can just pass required_local_disks false to these tests and keep the context where EBS would be useful.
There was a problem hiding this comment.
That's a good point. However, I do want to preserve the old tests as this is a temporary change. And hence commenting out the tests could be a better choice?
There was a problem hiding this comment.
If I set "require_local_disks": False and "require_attached_disks": True, in the test then it will test for ebs case. So we are achieving the result of old tests just by passing extra params.
ayushisingh29
force-pushed
the
feature/remove-ebs
branch
from
da86670
to
c17944e
Compare
ayushisingh29
force-pushed
the
feature/remove-ebs
branch
from
c17944e
to
da4f6d6
Compare
No description provided.