Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to disable default PropertiesConfigReader #534

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

xbaran
Copy link

@xbaran xbaran commented Dec 18, 2017

I find myself unable to disable default PropertiesConfigReader reader in InternalArchaiusModule which is package private and final.

I think more suitable place for default reader config is in ArchaiusModule as protected method.

So when I want to change PropertiesConfigReader for TypesafeConfigReader it would look like this:

install(new ArchaiusModule() {
@Override
protected void bindDefaultReaders() {}
@Override
protected void configureArchaius() {    Multibinder.newSetBinder(this.binder(),ConfigReader.class).addBinding().to(TypesafeConfigReader.class).asEagerSingleton();
}
});

Well I have another fix for TypesafeConfigReader that support Lists,Maps and Sets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants