Display HTML5 notifications when a task is no longer running #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes bringing up a set of machines can take a while, and the user would like to know when the process is complete. Currently, the user has to check back with Asgard every so often. This commit introduces the use of HTML5 notifications (which are not used if unsupported by the user's browser) to inform the user when the task has completed or failed.
|
asgard-pull-requests #472 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes bringing up a set of machines can take a while, and the user
would like to know when the process is complete. Currently, the user
has to check back with Asgard every so often. This commit introduces
the use of HTML5 notifications (which are not used if unsupported by
the user's browser) to inform the user when the task has completed or
failed.