-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issuer plugin for Google CA Manager #4816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for the work you've put into creating this new issuer plugin for the Google Certificate Authority Service. I've left a few minor comments in the code for things that could be improved. Before merging, we'd like to have some tests in place that cover the main functionality of your plugin, such as certificate creation, revocation, and fetching. Additionally, if you could add a changelog entry to make consumers aware of the new functionality, that'd be appreciated.
We appreciate your contribution and look forward to seeing the improvements and tests. If you need any help or clarification, feel free to ask.
Remove duplicate import Co-authored-by: Jared Crawford <[email protected]>
Fixed a typo in a role name Co-authored-by: Jared Crawford <[email protected]>
I have added some tests, but can you check that the tests are consistent enough with the rest of the project? I have tried to follow examples from other plugins, but not everything carries over. Similarly, I have added a changelog entry under 1.7.0 - |
@jmcrawford45 The build checks have been stuck all day, is there something wrong, or they just need more time? |
@jmcrawford45 now the build fails with an error |
This is a known upstream issue coverallsapp/github-action#205 I've temporarily disabled coveralls checks and will get your PR merged in today. Thanks again for your contribution and patience! |
A plugin that handles certificate issuance via Google CA Manager.
The plugin requires
GOOGLE_ACCOUNT_CREDENTIALS
config variable, which should point at the file containing credentials that Lemur is using to connect to Google Cloud Platform.These credentials normally would be for a service account that has permissions
privateca.certificates.update
,privateca.certificates.create
andprivateca.certificateAuthorities.get
This requires packages