Making sure connection errors don't create a new message signature ev…

…ery single time (#477) Co-authored-by: Sundaram Ananthanarayanan <[email protected]>
Netflix · Jul 14, 2023 · 4f2ed74 · 4f2ed74
1 parent 39dcbbe
commit 4f2ed74
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/mantis-runtime/src/main/java/io/mantisrx/runtime/source/http/impl/HttpSourceImpl.java b/mantis-runtime/src/main/java/io/mantisrx/runtime/source/http/impl/HttpSourceImpl.java
@@ -433,10 +433,11 @@ public Observable<HttpClientResponse<E>> call(Integer attempts) {
                 )
                 .doOnNext((HttpClientResponse<E> response) -> checkResponseIsSuccessful(response))
                 .doOnError((Throwable error) -> {
-                    logger.error(String.format(
-                            "Connecting to server %s failed: %s",
-                            clientContext.getServer(),
-                            error.getMessage()), error);
+                    logger.error(
+                        "Connecting to server {} failed: {}",
+                        clientContext.getServer(),
+                        error.getMessage(),
+                        error);
                     SUBSCRIPTION_FAILED.newEvent(observer, clientContext.getServer());
                     subscriptionFailedCounter.increment();
                     logger.info("server disconnected onError2: " + clientContext.getServer());