-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing client metrics #671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 19082dc.
Andyz26
requested review from
calvin681,
sundargates,
hmitnflx and
fdc-ntflx
as code owners
May 10, 2024 23:44
Andyz26
temporarily deployed
to
Integrate Pull Request
May 10, 2024 23:44
— with
GitHub Actions
Inactive
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle.
|
Andyz26
temporarily deployed
to
Integrate Pull Request
May 13, 2024 23:15
— with
GitHub Actions
Inactive
Andyz26
temporarily deployed
to
Integrate Pull Request
May 14, 2024 00:08
— with
GitHub Actions
Inactive
fdc-ntflx
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The SSEWorkerConnection clients don't apply the client listener factory, thus missing certain metrics on the client side, e.g. tcpClient bytesRead.
The fix here is to re-apply the listener similar to how rxnetty clients got it.
Checklist
./gradlew build
compiles code correctly./gradlew test
passes all tests