Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing client metrics #671

Merged
merged 3 commits into from
May 14, 2024
Merged

Fix missing client metrics #671

merged 3 commits into from
May 14, 2024

Conversation

Andyz26
Copy link
Collaborator

@Andyz26 Andyz26 commented May 10, 2024

Context

The SSEWorkerConnection clients don't apply the client listener factory, thus missing certain metrics on the client side, e.g. tcpClient bytesRead.

The fix here is to re-apply the listener similar to how rxnetty clients got it.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link

github-actions bot commented May 10, 2024

Test Results

517 tests  ±0   511 ✅ ±0   7m 16s ⏱️ -6s
134 suites ±0     6 💤 ±0 
134 files   ±0     0 ❌ ±0 

Results for commit 31579cc. ± Comparison against base commit e3af492.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 10, 2024

Uploaded Artifacts

To use these artifacts in your Gradle project, paste the following lines in your build.gradle.

resolutionStrategy {
    force "io.mantisrx:mantis-common-serde:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-common:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-discovery-proto:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-client:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-remote-observable:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-network:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-runtime-executor:0.1.0-20240514.000828-73"
    force "io.mantisrx:mantis-runtime:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-shaded:0.1.0-20240514.000828-536"
    force "io.mantisrx:mantis-runtime-loader:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-testcontainers:0.1.0-20240514.000828-207"
    force "io.mantisrx:mantis-connector-iceberg:0.1.0-20240514.000828-536"
    force "io.mantisrx:mantis-rxcontrol:0.1.0-20240514.000828-11"
    force "io.mantisrx:mantis-connector-kafka:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-connector-publish:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-control-plane-client:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-control-plane-core:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-control-plane-server:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-core:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-groupby-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-jobconnector-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-connector-job:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-examples-mantis-publish-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-twitter-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-sine-function:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-wordcount:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-publish-core:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-server-agent:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-synthetic-sourcejob:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-publish-netty-guice:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-source-job-kafka:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-publish-netty:0.1.0-20240514.000828-530"
    force "io.mantisrx:mantis-source-job-publish:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-control-plane-store-dynamodb:0.1.0-20240514.000828-25"
    force "io.mantisrx:mantis-server-worker-client:0.1.0-20240514.000828-531"
}

@Andyz26 Andyz26 temporarily deployed to Integrate Pull Request May 13, 2024 23:15 — with GitHub Actions Inactive
@Andyz26 Andyz26 temporarily deployed to Integrate Pull Request May 14, 2024 00:08 — with GitHub Actions Inactive
@Andyz26 Andyz26 changed the title [WIP] draft pr on missing metrics Fix missing client metrics May 14, 2024
@Andyz26 Andyz26 merged commit 56e0a1c into master May 14, 2024
5 checks passed
@Andyz26 Andyz26 deleted the andyz/testRxNettyChange branch May 14, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants