Emit failover events into the job autoscaler events to allow autoscaling decisions #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmitnflx
requested review from
calvin681,
sundargates,
Andyz26 and
fdc-ntflx
as code owners
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
hmitnflx
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle. |
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
hmitnflx
changed the title
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
hmitnflx
commented
Jun 15, 2024
| @@ -341,7 +341,12 @@ public int getDesiredWorkersForScaleUp(final int increment, final int numCurrent | |||
| return numCurrentWorkers; | |||
| } else { | |||
| final int maxWorkersForStage = stageSchedulingInfo.getScalingPolicy().getMax(); | |||
| desiredWorkers = Math.min(numCurrentWorkers + increment, maxWorkersForStage); | |||
| if (reason == ScalingReason.AutoscalerManager) { | |||
There was a problem hiding this comment.
todo: this condition is no longer correct.
Andyz26
reviewed
Jun 19, 2024
| @@ -86,7 +86,7 @@ public enum ScalingReason { | |||
| RPS, | |||
| JVMMemory, | |||
| SourceJobDrop, | |||
| FailoverAware | |||
| AutoscalerManager | |||
There was a problem hiding this comment.
AutoscalerManager vs RPS/JVMMemory seems a bit strange?
There was a problem hiding this comment.
maybe "AutoscalerManagerEvent"
| @@ -39,6 +39,10 @@ default boolean isScaleDownEnabled() { | |||
| return true; | |||
| } | |||
|
|
|||
| default double getCurrentValue() { | |||
There was a problem hiding this comment.
can you add a document here about why it's -1?
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
hmitnflx
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Andyz26
approved these changes
Jul 10, 2024
| @@ -416,6 +417,19 @@ public void onNext(MetricData metricData) { | |||
| }; | |||
| } | |||
|
|
|||
| private void maybeEmitAutoscalerManagerEvent(int numWorkers) { | |||
| final double currentValue = jobAutoscalerManager.getCurrentValue(); | |||
| if (currentValue >= 0.0 && currentValue <= 100.0) { | |||
There was a problem hiding this comment.
can you add a inline doc about this logic? why it's 0 to 100?
hmitnflx
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
hmitnflx
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Explain context and other details for this pull request.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests