Fix WorkersByJobId: Filtered Workers Not Empty Check #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I forgot to update the previous PR with this fix. We have enough cruft lying around from all of the churn, that we hit cases where we get a NPE when we cannot parse the worker payload in
getAllWorkersByJobId
. This checks to ensureworkers
is not empty before referencing the first element ofworkers
.Checklist
./gradlew build
compiles code correctly./gradlew test
passes all tests