Allow user specified concurrency for Scalar to Group and Group to Scalar #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crioux-stripe
requested review from
calvin681,
sundargates,
Andyz26,
hmitnflx and
fdc-ntflx
as code owners
crioux-stripe
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
hmitnflx
approved these changes
Oct 7, 2024
| @@ -33,7 +33,12 @@ public abstract class KeyValueStageConfig<T, K, R> extends StageConfig<T, R> { | |||
| private final Codec<K> keyCodec; | |||
|
|
|||
| public KeyValueStageConfig(String description, Codec<?> inputKeyCodec, Codec<T> inputCodec, Codec<K> outputKeyCodec, Codec<R> outputCodec, INPUT_STRATEGY inputStrategy, List<ParameterDefinition<?>> params) { | |||
| super(description, inputKeyCodec, inputCodec, outputCodec, inputStrategy, params); | |||
| super(description, inputKeyCodec, inputCodec, outputCodec, inputStrategy, params, DEFAULT_STAGE_CONCURRENCY); | |||
There was a problem hiding this comment.
nit: you could call the other constructor in this class instead of duplicate call to super + keyCodec assignment.
There was a problem hiding this comment.
Good call. Pushed a change.
| @@ -116,6 +118,12 @@ public Config<T, K, R> concurrentInput() { | |||
| return this; | |||
| } | |||
|
|
|||
| public Config<T, K, R> concurrentInput(final int concurrency) { | |||
There was a problem hiding this comment.
this could cause issues, no?
There was a problem hiding this comment.
I went looking around and we do allocate the same key to the same thread every time. We have concurrency either way, this just lets the user specify it precisely, unless I'm misunderstanding the if/else that contains the linked line.
crioux-stripe
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
crioux-stripe
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
crioux-stripe
deleted the
crioux-stripe/scalar-to-group-group-to-scalar-concurrency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The default concurrency for
ScalarToGroupandGroupToScalarstages is-1and thus relies on the number of inner observables when executing the stage. There may be cases such as CPU bound stages where the user wants fine grained control over how many threads are executing the stage logic.Some discussion in #681 indicates a desire for this, but I agree with @calvin681 that changing defaults shouldn't be done lightly as users have come to expect certain threading behavior with the stages. I think this represents a compromise where unaware users can continue with the default and power users can begin to control threading.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests