Add if statement to remote.Close() call #130
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an error in
listener.Accept()
remote
object can be nil.rend/server/listen.go
Line 122 in d3db570
Calling
remote.Close()
in this line causes a panic.rend/server/listen.go
Line 125 in d3db570
We noticed this behaviour because this error
Error accepting connection from remote: accept tcp [::]:11211: accept4: too many open files
causes our implementation to panic.Since the wanted behavior is to continue the
listener.Accept()
loop in case of error, we should wrap this particularremote.Close()
call with anif remote != nil
statementFixes #129