Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ips): rule management #485

Merged
merged 5 commits into from
Jan 16, 2025
Merged

feat(ips): rule management #485

merged 5 commits into from
Jan 16, 2025

Conversation

Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Jan 15, 2025

Added:

  • Removal of disabled rules
  • Added rule removal
  • Listing of disabled rules

Ref: NethServer/nethsecurity#1017

@Tbaile Tbaile requested a review from andre8244 January 15, 2025 14:37
@Tbaile Tbaile mentioned this pull request Jan 15, 2025
Closed
andre8244
andre8244 reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@andre8244 andre8244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add header comments (copyright stuff) to all IPS files

src/i18n/en/translation.json Outdated Show resolved Hide resolved
src/components/standalone/security/ips/IpsEnableRuleModal.vue Show resolved Hide resolved
src/components/standalone/security/ips/IpsEnableRuleModal.vue Show resolved Hide resolved
src/i18n/en/translation.json Outdated Show resolved Hide resolved
src/components/standalone/security/ips/IpsDisabledRules.vue Outdated Show resolved Hide resolved
src/components/standalone/security/ips/IpsDisabledRules.vue Show resolved Hide resolved
src/components/standalone/security/ips/IpsDisabledRules.vue Show resolved Hide resolved
@Tbaile Tbaile requested a review from andre8244 January 16, 2025 10:30
@Tbaile Tbaile merged commit 7a22db0 into issue-976 Jan 16, 2025
3 checks passed
@Tbaile Tbaile deleted the issue-1017 branch January 16, 2025 11:22
Tbaile added a commit that referenced this pull request Jan 16, 2025
@Tbaile
feat(ips): rule management (#485)
9b15797
Tbaile added a commit that referenced this pull request Jan 20, 2025
@Tbaile
feat(ips): rule management (#485)
1ad2847
Tbaile added a commit that referenced this pull request Jan 22, 2025
@Tbaile
feat(ips): rule management (#485)
855db17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre8244 andre8244 andre8244 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tbaile @andre8244