feat(ns8): add DNS server running check and disabled dns toggle #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
sdl-6982
branch
3 times, most recently
from
b4103ff to
5b1197a
Compare
Co-authored-by: Davide Principi <[email protected]>
DavidePrincipi
approved these changes
Aug 1, 2024
Tbaile
approved these changes
Aug 2, 2024
Tbaile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a check in the UI to verify if the tcp/53 or the udp/53 is not already used. The toggle and the button is disabled when the check is true.
The test should take care that the dns ports are used from another instances, we test if the dnsmasq configuration is set to False: dns-server.enabled == False
NethServer/dev#6982