Adding Hash Solidity compatible example #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIll add a contract address later, after the merge (so I can use remix to deploy easily) |
julio4
requested changes
Nov 20, 2023
listings/ch02-advanced-concepts/hash_solidity_compatible/src/tests.cairo
Outdated
Show resolved
Hide resolved
listings/ch02-advanced-concepts/hash_solidity_compatible/src/contract.cairo
Outdated
Show resolved
Hide resolved
|
Changes requested done! |
julio4
approved these changes
Nov 21, 2023
|
This is not entirely correct - see #123 |
|
Thank you for pointing this out! @julienbrs Do you still want to work on this? |
|
Thanks for the full explanation, I'll start working on it in a few days if it's okay for you @julio4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Issue:**closes #14
Description
Added an example to get the same hash result as the solidity's keccak.