-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip epochs at the beginning #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should skip epochs starting from registration, not from the node's start. However, this might be sufficient for the PoC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of epochsToEkip
in the beginning, put in the config the timestamp of the registration. Then, you can check if this preconfer is registered and is supposed to dtart duties based on that.
Skipping epochs on the node start does not make sense
OK. Why timestamp, and why in the config? The config is supposed to provide some parameters not to store some state. I'd rather keep epochs to skip in the config and start skipping them after registration. As I operate on epochs, it's less calculation if I check how many epoch passed from the registration. |
Calculation is negligible. I thought we can put it in config instead of having to store it somewhere else. But i think you are right, we should have a file or a db that saves our state (including timestamp of the registeration,) |
So you want to store it in some protected storage, in case of the crash/restart of the application? |
Not needed for now, maybe later we will use a state file |
No description provided.