Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration - submit and registered event #76

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

mskrzypkows
Copy link
Collaborator

No description provided.

@mskrzypkows mskrzypkows marked this pull request as ready for review August 22, 2024 14:19
Copy link
Collaborator

@mikhailUshakoff mikhailUshakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall! However, we need to refactor the register_preconfer function.

match log {
Ok(log) => {
tracing::info!("Received PreconferRegistered for: {}", log.0.preconfer);
if log.0.preconfer == self.avs_node_address {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should clearly define what preconfer, avs_node, and validator mean, and ensure we're using these terms consistently throughout the codebase.

@mskrzypkows
Copy link
Collaborator Author

I'll merge it and improve register_preconfer in the next PR

@mskrzypkows mskrzypkows merged commit 181a57f into master Aug 23, 2024
1 check passed
@mskrzypkows mskrzypkows deleted the ms/cli_arguments_registration branch August 23, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants