Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to .NET 8 #59

Merged
merged 10 commits into from
Dec 14, 2023
Merged

Upgrade to .NET 8 #59

merged 10 commits into from
Dec 14, 2023

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Dec 4, 2023

No description provided.

@flcl42 flcl42 requested a review from rubo as a code owner December 4, 2023 10:37
@flcl42 flcl42 requested a review from chertby December 4, 2023 10:37
@flcl42 flcl42 changed the title Migrate dotnet8 Upgrade to .NET 8 Dec 4, 2023
rubo
rubo reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@rubo rubo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on with merging, please.

@flcl42 flcl42 requested a review from rubo December 8, 2023 10:04
rubo
rubo reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many warnings mostly about nullable annotations. Would be great to resolve them. If not in this PR, maybe separately.

src/cs-multihash Show resolved Hide resolved
@flcl42
Copy link
Contributor Author

flcl42 commented Dec 12, 2023

There are so many warnings mostly about nullable annotations. Would be great to resolve them. If not in this PR, maybe separately.

#63 let's fix it later

@flcl42 flcl42 requested a review from rubo December 12, 2023 10:04
@flcl42 flcl42 merged commit 136c739 into main Dec 14, 2023
2 checks passed
@flcl42 flcl42 deleted the migrate-dotnet8 branch December 14, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubo rubo rubo approved these changes

@chertby chertby Awaiting requested review from chertby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flcl42 @rubo