-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web socket updates #2409
Web socket updates #2409
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2409 +/- ##
==========================================
- Coverage 74.60% 74.38% -0.23%
==========================================
Files 113 113
Lines 13052 13136 +84
==========================================
+ Hits 9738 9771 +33
- Misses 2583 2627 +44
- Partials 731 738 +7 ☔ View full report in Codecov by Sentry. |
19dbae4
to
448f8df
Compare
448f8df
to
a7f56f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just some nitpicks
a382d44
to
cfb51dd
Compare
62f2bd1
to
f3110a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review, I'll continue later
5c930aa
to
a566166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix nil blockid interface
remove equal
This reverts commit 48b4202.
Co-authored-by: Daniil Ankushin <[email protected]> Signed-off-by: Ng Wei Han <[email protected]>
da54207
to
838719f
Compare
This PR introduces the most recent changes to websocket specs, please see each commit.
Todo:
blockID = pending
.