feat(onboarding): Add rpc endpoint juno_getBlockWithTxnHashesAndReceipts #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2429 +/- ##
==========================================
+ Coverage 74.42% 74.51% +0.08%
==========================================
Files 113 113
Lines 13135 13156 +21
==========================================
+ Hits 9776 9803 +27
Misses 2619 2619
+ Partials 740 734 -6 ☔ View full report in Codecov by Sentry. |
|
LGTM! Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding implementation task 1: endpoint
juno_getBlockWithTxnHashesAndReceiptsNote: I saw other helper function whose visibility was public, so, I changed the visibility of
adaptBlockHeaderto be able to use it in the tests. Let me know if it's something we don't want to do, I'll revert it and change my test.I set it as draft just to make sure it doesn't get merged.