Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding): Add rpc endpoint juno_getNodesFromRoot #2432

Closed
wants to merge 3 commits into from

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 6, 2025

Onboarding implementation task 2: endpoint juno_getNodesFromRoot

I set it as draft just to make sure it doesn't get merged.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.33%. Comparing base (198443f) to head (83bda67).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rpc/block.go 47.05% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2432      +/-   ##
==========================================
- Coverage   74.42%   74.33%   -0.10%     
==========================================
  Files         113      113              
  Lines       13135    13155      +20     
==========================================
+ Hits         9776     9779       +3     
- Misses       2619     2640      +21     
+ Partials      740      736       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hudem1 hudem1 added the onboarding Part of onboarding exercise pack label Feb 7, 2025
@rodrigo-pino
Copy link
Contributor

LGTM! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Part of onboarding exercise pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants