Skip to content

Commit

Permalink
Merge pull request #8 from NethermindEth/feat/add_nethermind
Browse files Browse the repository at this point in the history
fix: build on nethermind, buildx labels
  • Loading branch information
stdevMac authored Oct 2, 2024
2 parents 94c66df + 4acf6e1 commit 2d1df56
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,15 @@ jobs:
- name: Build and push the Docker image using buildx
run: |
# Convert labels to individual --label flags
# Convert labels to individual --label flags with proper quoting
labels=""
while IFS= read -r line; do
labels="$labels --label $line"
labels="$labels --label \"${line}\""
done <<< "${{ steps.meta.outputs.labels }}"
# Debug: Print the constructed docker buildx build command
echo "docker buildx build --platform ${{ matrix.platform }} --file nethermind/Dockerfile --tag ${{ steps.meta.outputs.tags }} $labels --build-arg BUILD_CONFIG=release --build-arg TARGETARCH=${{ matrix.platform }} . --push"
# Run the docker buildx build command
docker buildx build \
--platform ${{ matrix.platform }} \
Expand All @@ -139,4 +139,3 @@ jobs:
--build-arg BUILD_CONFIG=release \
--build-arg TARGETARCH=${{ matrix.platform }} \
. --push

6 changes: 2 additions & 4 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ services:
volumes:
- ${HOST_DATA_DIR}:/data
env_file:
# select your network here:
# - .env.sepolia
- .env.sepolia
# - .env.mainnet
node:
build:
Expand All @@ -28,6 +27,5 @@ services:
- "6060:6060" # pprof
command: [ "bash", "./op-node-entrypoint" ]
env_file:
# select your network here:
# - .env.sepolia
- .env.sepolia
# - .env.mainnet

0 comments on commit 2d1df56

Please sign in to comment.