Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thiagodeev/fix unreturned tx hash #614

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

thiagodeev
Copy link
Collaborator

Fixes #611

@thiagodeev thiagodeev marked this pull request as draft August 19, 2024 13:55
@thiagodeev
Copy link
Collaborator Author

thiagodeev commented Aug 19, 2024

There's a conflict between the deprecated version of the mock module (github.com/golang/mock) vs the newest (go.uber.org/mock). I'll fix it

@thiagodeev thiagodeev marked this pull request as ready for review August 19, 2024 14:07
@thiagodeev thiagodeev force-pushed the thiagodeev/fix-unreturned-tx-hash branch from decb3cf to 533cc1a Compare August 20, 2024 12:48
@thiagodeev thiagodeev merged commit 55e49de into main Aug 20, 2024
6 checks passed
@thiagodeev thiagodeev deleted the thiagodeev/fix-unreturned-tx-hash branch August 20, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing transaction_hash field from TransactionByHash and TransactionByBlockIdAndIndex
2 participants