Thiagodeev/rpcv08 txn status #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagodeev
commented
Sep 30, 2024
thiagodeev
commented
Sep 30, 2024
rianhughes
reviewed
Oct 1, 2024
rianhughes
reviewed
Oct 1, 2024
|
Might be good to leave a note in the PR description that tests for these changes need implemented once full nodes support this rpc version |
rianhughes
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#623
This PR aims to implement some RPC v0.8.0 updates to starknet.go. The ones addressed by this PR are:
Methods
starknet_getTransactionStatus
Components
TXN_STATUS_RESULT
FEE_ESTIMATE
Note: as the RPC v0.8.0 has not been released yet, we can't fully test these changes as the nodes haven't implemented them yet. They will be updated before merge into main