Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for to_hierarchical_dataframe for the icephys tables #1404

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Aug 23, 2021

This PR is in response to hdmf-dev/hdmf#665 which identified an issue where conversion of the icephys metadata tables to a hierarchical dataframe fails if a table contains a VectorIndex column. This PR adds corresponding tests in PyNWB to make sure this case is tests here. A corresponding PR on HDMF will follow as well to fix this issue.

How to test the behavior?

From hdmf-dev/hdmf#665

from pynwb.testing import create_icephys_testfile
from hdmf.common.hierarchicaltable import to_hierarchical_dataframe
nwbfile = create_icephys_testfile()
nwbfile.icephys_experimental_conditions.add_column('newcol', 'abc', data = [1,2,3], index = [2,3])
to_hierarchical_dataframe(nwbfile.icephys_experimental_conditions)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel requested a review from rly August 23, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant