-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/getcachednamespaces #1432
Enh/getcachednamespaces #1432
Conversation
@rly this issue would be good to address in the next minor release |
Codecov Report
@@ Coverage Diff @@
## dev #1432 +/- ##
==========================================
- Coverage 78.42% 78.34% -0.09%
==========================================
Files 37 37
Lines 2777 2780 +3
Branches 493 493
==========================================
Hits 2178 2178
- Misses 518 521 +3
Partials 81 81
Continue to review full report at Codecov.
|
@oruebel what do you think about also extracting most of the code in |
that makes sense |
We agreed to incorporate this feature into |
would this PR be merged/released some time soon? |
@yarikoptic I'm close to finishing something very similar that also integrates with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointed out some minor coding improvements.
Co-authored-by: John T. Wodder II <[email protected]>
Co-authored-by: John T. Wodder II <[email protected]>
Thanks, @jwodder ! |
this one is open since July -- any plans to finalize/release it ? |
@yarikoptic thanks for following up. I think this one got put on hold while #1494 was being worked out and I think that PR may potentially already address that issue. I'll bring it up during our developer meeting tomorrow to see whether this PR should be merged or whether it should be closed in favor of #1494 |
@yarikoptic This has indeed already been merged in #1511, this can be closed here and I'll get a PR up on the dandi-cli to adjust the API calls to have this functionality |
Closing this PR since this has been addressed in #1511 |
Motivation
#1431
Relate to dandi/dandi-cli#917
This PR extracts the code to determine the cached extension namespace to use for validation from the main function of the command line validator to a separate function so that the code can be used outside to validate files against cached namespaces.
Checklist
flake8
from the source directory.