Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectrodesTable #1890

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

ElectrodesTable #1890

wants to merge 16 commits into from

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Apr 18, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.12%. Comparing base (dc98e84) to head (06cf465).

Files with missing lines Patch % Lines
src/pynwb/io/file.py 58.33% 4 Missing and 1 partial ⚠️
src/pynwb/file.py 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dc98e84) and HEAD (06cf465). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (dc98e84) HEAD (06cf465)
integration 4 0
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1890      +/-   ##
==========================================
- Coverage   91.85%   83.12%   -8.74%     
==========================================
  Files          27       27              
  Lines        2689     2714      +25     
  Branches      701      706       +5     
==========================================
- Hits         2470     2256     -214     
- Misses        145      361     +216     
- Partials       74       97      +23     
Flag Coverage Δ
integration ?
unit 83.12% <81.25%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Collaborator Author

mavaylon1 commented Oct 2, 2024

@rly This is at the point where everything works on my end, I added some notes for future reference, and should be good to go. Let me know what you think. Let's see if we can release the schema asap after merging the electrodes schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant