forked from glitch-soc/mastodon
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Myspace Mode - Chapter 1: User Custom CSS #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it's loaded on public, not when logged in. damn it. checkpointing so i can return here if needed
ok @hobgoblina this works now, with css changing on page transitions and not requiring haml embeds and stuff, but i can't get the test to work, it seems to not be running the |
hobgoblina
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of Myspace Mode.
This PR adds the ability to set user-custom CSS in the profile settings page, and it is then applied on the account page.
Wiki page: https://wiki.neuromatch.social/Myspace_Mode
Implementation
Implementation is just about as straightforward as you can be. Added a nullable text column to an account, added it to a form, put it in the haml template when viewing that account's page.
re: the name - i didn't want to just call it
css
orcustom_css
because i also want to add the ability to add css that gets applied for you when you are viewing the rest of the site - so "public account css that styles your profile" and "let me tweak the way masto looks for myself real quick" as two separable thingsTODO