try to fix stutter

NewAmsterdamLabs · Dec 11, 2023 · 964c963 · 964c963
1 parent 0211df7
commit 964c963
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheet.swift b/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheet.swift
@@ -209,7 +209,8 @@ public class PaymentSheet {
     }
 
     public func presentError(_ error: Error) {
-        // VBC TODO
+        let psvc = self.findPaymentSheetViewController()
+        psvc?.presentError(error)
     }
 
     /// Deletes all persisted authentication state associated with a customer.

diff --git a/...t/StripePaymentSheet/Source/PaymentSheet/ViewControllers/PaymentSheetViewController.swift b/...t/StripePaymentSheet/Source/PaymentSheet/ViewControllers/PaymentSheetViewController.swift
@@ -63,6 +63,7 @@ class PaymentSheetViewController: UIViewController {
     private(set) var error: Error?
     private var isPaymentInFlight: Bool = false
     private(set) var isDismissable: Bool = true
+    private var isConfirming: Bool = false
 
     // MARK: - Views
 
@@ -449,16 +450,18 @@ class PaymentSheetViewController: UIViewController {
         pay(with: paymentOption)
     }
 
-    func presentError() {
-        // VBC TODO: error handling from external sources
+    func presentError(_ error: Error) {
+        isConfirming = false
     }
 
     func pay(with paymentOption: PaymentOption) {
         view.endEditing(true)
         isPaymentInFlight = true
         // Clear any errors
         error = nil
-        updateUI()
+        if !isConfirming {
+            updateUI()
+        }
         if isConfirmed {
             // Confirm the payment with the payment option
             let startTime = NSDate.timeIntervalSinceReferenceDate
@@ -515,8 +518,10 @@ class PaymentSheetViewController: UIViewController {
                     }
                 }
             }
+            isConfirming = false
         } else {
             self.paymentOption = paymentOption
+            isConfirming = true
             delegate?.paymentSheetViewControllerDidTapBuy(self)
         }
     }