-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helper is able to cancel accepted request #137
Open
hunnihundert
wants to merge
10
commits into
develop
Choose a base branch
from
feature/124_ablility_to_cancel_accepted_request
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
helper is able to cancel accepted request #137
hunnihundert
wants to merge
10
commits into
develop
from
feature/124_ablility_to_cancel_accepted_request
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-stefanov
requested changes
Jun 14, 2020
app/src/main/java/app/nexd/android/ui/helper/detail/HelperDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/nexd/android/ui/helper/detail/HelperDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/nexd/android/ui/helper/detail/HelperDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/nexd/android/ui/helper/detail/HelperDetailViewModel.kt
Outdated
Show resolved
Hide resolved
…odel to Fragment added progress to ViewModel and let Fragment observe it for showing status, indicating loading (TODO) and going back to the request overview removed unnecessary .subscribeOn(io), switched from .blockingSubscribe() to .subscribeBy() for accepting/declining request added strings for feedback (SnackBar) to user in case of accepted/declined requests
…aBindingAdapters now all cases are covered (normal, bold, italic, italic_bold) by using all lower snake case, in case of non recognized value "normal" will be used
There is a build error now because of DefaultSnackbar. |
…spite there being none
… previous commits/merges
…gment removed with above mentioned related DataBindingAdapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #124