-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component, Screen Preview 구성 #153
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
271b600
ComponentPreview annotation class 추가
easyhooon d57b743
LoadingScreen 네이밍 변경
easyhooon 2284d9b
:core:ui 모듈 화면을 구성하는 컴포넌트들 프리뷰 추가
easyhooon 4903704
DevicePreview annotation class 추가
easyhooon 9074c79
feature 모듈 component, screen 프리뷰 추가
easyhooon 54c9103
SplashScreen preview render problem 해결
easyhooon 12ea5f9
spotless check success
easyhooon d4a4bde
BandalartBottomSheet preview 추가
easyhooon ba2dc29
HomeScreen preview 내에 dummy bandalart data 적용
easyhooon 4a4f590
사용하지 않는 MainViewModel 제거
easyhooon b63a9b8
chore: FixedSizeText 사용된 부분 nonScaleSp 속성 제거, modifier 파라미터 순서 변경
easyhooon ef564e9
spotless check success
easyhooon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
98 changes: 0 additions & 98 deletions
98
app/src/main/kotlin/com/nexters/bandalart/android/MainViewModel.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
core/ui/src/main/kotlin/com/nexters/bandalart/android/core/ui/ComponentPreview.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package com.nexters.bandalart.android.core.ui | ||
|
||
import androidx.compose.ui.tooling.preview.Preview | ||
|
||
@Preview(showBackground = true) | ||
annotation class ComponentPreview |
15 changes: 15 additions & 0 deletions
15
core/ui/src/main/kotlin/com/nexters/bandalart/android/core/ui/DevicePreview.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package com.nexters.bandalart.android.core.ui | ||
|
||
import androidx.compose.ui.tooling.preview.Preview | ||
|
||
@Preview( | ||
name = "Galaxy S23 Ultra", | ||
showBackground = true, | ||
device = "spec:width=360dp,height=772dp,dpi=411", | ||
) | ||
@Preview( | ||
name = "Galaxy S23", | ||
showBackground = true, | ||
device = "spec:width=360dp,height=800dp,dpi=500", | ||
) | ||
annotation class DevicePreview |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 디바이스를 두개를 설정해놓으면 어떤 식으로 볼 수 있게 되는거야? 탭이 이렇게 생기는 건가? 둘 다 볼 수 있는?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch checkout 해서 확인해보면 알 수 있긴 한데 이렇게 각각의 기기에서 동일한 화면에 대해 어떻게 그려지는지 확인해볼 수 있음!
생각해보니까 두 기기가 크게 유의미하게 다르진 않은데 그냥 같은 기기에 대해 세로모드, 가로모드 이렇게 만들어놓는게 더 낫긴하겠다., 아니면 하나는 핸드폰 하나는 태블릿 이런식으로
디바이스 사이즈 알아와서 그것도 나중에 추가해봐야겄어